Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for the Bolt Payment Method #49

Merged

Conversation

piyushswain
Copy link
Contributor

After a recent update, now Bolt has been added as an installable payment method during Solidus installation.

The doc has been updated to reflect the same information.

@waiting-for-dev
Copy link
Contributor

waiting-for-dev commented Aug 4, 2022

Thanks! It looks good. We need to put it on hold until solidusio/solidus#4425 is merged. We might need to revisit if PayPal gets removed as an option (their SDK doesn't support Ruby 3).

@elia
Copy link
Member

elia commented Oct 11, 2022

solidusio/solidus#4425 has been closed, but solidusio/solidus_frontend#14 has been merged, but PayPal has been since disabled.

I would suggest to merge anyway, knowing that 2.3 will restore it, @waiting-for-dev @piyushswain is that ok with you?

@waiting-for-dev
Copy link
Contributor

Yeah. The edge guides track master, so let's wait until we have added the payment methods in core.

@elia elia force-pushed the update_documentation_for_bolt branch from 6465290 to 7e9c89d Compare January 24, 2023 08:55
@elia elia force-pushed the update_documentation_for_bolt branch from 7e9c89d to 0fcff11 Compare January 24, 2023 08:56
@elia
Copy link
Member

elia commented Jan 24, 2023

I rebased fixing the conflict and back porting to 3.2

@elia elia force-pushed the update_documentation_for_bolt branch from 0fcff11 to 3f8886d Compare January 24, 2023 09:11
After a recent update, now Bolt has been added as a installable payment method
during Solidus installation.

The doc has been updated to reflect the same information.
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @piyushswain & @elia. I improved the text a bit.

Next it will => Next, it will
with solidus => with Solidus
.Currently => . Currently
Solidus comes packaged => it comes packaged

@waiting-for-dev waiting-for-dev merged commit 91be554 into solidusio:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants