Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Lifecycle for v24.06 (2): remove Compat #4533

Merged
merged 20 commits into from
Mar 15, 2024

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Feb 26, 2024

See #4532 to review readable changes.
In addition, this PR removes the entire Sofa/Component/Compat layer.
This PR depends on :

[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/265]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/139]
[ci-depends-on https://github.com/sofa-framework/CGALPlugin/pull/14]
[ci-depends-on https://github.com/sofa-framework/Registration/pull/12]
[ci-depends-on https://github.com/sofa-framework/PluginExample/pull/6]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 26, 2024
@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2024

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@hugtalbot hugtalbot changed the title 202402 lifecycle v2406 2 [all] Lifecycle for v24.06 (2): remove Compat Feb 26, 2024
@sofa-framework sofa-framework deleted a comment from sofabot Feb 26, 2024
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2024

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor Author

InvertibleFVM is failing ..

@hugtalbot
Copy link
Contributor Author

hugtalbot commented Feb 27, 2024

FVM plugin should now be fixed

[ci-build][with-all-tests]

@sofa-framework sofa-framework deleted a comment from sofabot Feb 27, 2024
@sofa-framework sofa-framework deleted a comment from sofabot Feb 27, 2024
@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

@sofa-framework sofa-framework deleted a comment from sofabot Feb 27, 2024
@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

@hugtalbot hugtalbot marked this pull request as draft February 27, 2024 09:21
@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #11.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #13.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2024

[ci-depends-on] detected during build #14.

To unlock the merge button, you must

@hugtalbot hugtalbot marked this pull request as ready for review February 27, 2024 21:14
@sofabot
Copy link
Collaborator

sofabot commented Feb 28, 2024

[ci-depends-on] detected during build #15.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 28, 2024

[ci-depends-on] detected during build #16.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 28, 2024

[ci-depends-on] detected during build #17.

To unlock the merge button, you must

@hugtalbot hugtalbot requested a review from fredroy February 28, 2024 21:17
@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 13, 2024
@sofabot
Copy link
Collaborator

sofabot commented Mar 14, 2024

[ci-depends-on] detected during build #18.

To unlock the merge button, you must

@fredroy
Copy link
Contributor

fredroy commented Mar 14, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Mar 14, 2024

[ci-depends-on] detected during build #19.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy fredroy merged commit 680ce0e into sofa-framework:master Mar 15, 2024
11 checks passed
bakpaul pushed a commit to bakpaul/sofa that referenced this pull request Mar 21, 2024
* [all] Lifecycle for v24.06 (1)

* removed files

* forgotten Axis.h

* Complete SOFA_ATTRIBUTE_DEPRECATED ... v24.06 into DISABLED

* start removing ATTRIBUTE_DISABLED v23.06 and fix EdgeSetGeometryAlgorithms

* delete all v24.06 disabled functions

* Remove all data and attributes removed since v23.06

* [all] Lifecycle v24.06 (2): remove Compat

* Update last uses of type::Vector3

* missing change Vector3 in OmniDriverEmu.cpp

* Fix compilation GeomagicEmulator

* Fix TaskScheduler

* mising fixes

* fix reference to driver

* Fix warning in VariationalSymplecticSolver example scene

* Remove symbol in fwd.h for Win compilation

* Remove symbol in DAGSimulation for Win compilation

* Remove symbol in LCPcal and ColourPickingVisitor for Win compilation
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants