Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scenes] Fix python scenes using the new Section Material components #126

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jan 10, 2024

Fix the basic examples scenes using same parameters as the xml versions. (also clean warnings)

Also fix the Scene_Cochlea.py

Not sure if the behavior is correct, this is a screenshot of what I get:

Scene_Cochlea_00000001

fix #122

@epernod epernod added pr: fix pr: status to review To notify reviewers to review this pull-request labels Jan 10, 2024
@epernod epernod changed the title [scenes] Fix python scenes [scenes] Fix python scenes using the new Section Material components Jan 10, 2024
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxbilger
Copy link
Contributor

This should fix #122

@fredroy fredroy merged commit 2026a2e into sofa-framework:master Jan 15, 2024
4 checks passed
@epernod epernod deleted the inf_python_scene branch January 15, 2024 23:27
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of Scene_Cochlea
3 participants