Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative path to references files into regression-tests files #125

Merged

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Jan 8, 2024

This PR is based on PR #56 of Regression.

This PR fixes the problem of running regression tests in plugins when their references are inside of the plugin and not Regression (e.g. BeamAdapter)

The idea is to have a stand alone *.regression.tests file that also includes the relative path of the reference folder. This is meant to be placed at the top of the reference file in a relative manne. This allows two things :

  1. Having a stand alone file ease the process of finding the reference folder for any new comer
  2. Having a stand alone file ease the process of automatizing the retrieval of new regression test along with their reference folder without the need of modifying anything in the CI script.

@epernod epernod added pr: fix pr: status ready Approved a pull-request, ready to be squashed labels Jan 10, 2024
@epernod epernod merged commit 107ede1 into sofa-framework:master Jan 10, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants