-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Fix subplugin regression tests #4420
[All] Fix subplugin regression tests #4420
Conversation
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
Note: we only have regressions for BeamAdapter, Multithreading and SphFluid |
Create Issue to rethink the way it is done: maybe centralize the regression-tests files in Regression plugin. This would require multiple changes like being able to find the path of all plugins to find the scenes and the regression files when they are inside of the plugin instead of Regression. --> #4424 |
* Add relative path to references files into regression-tests files * fix typo
[ci-depends-on https://github.com/sofa-framework/Regression/pull/56]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/125]
This PR is based on PR #56 of Regression.
This PR fixes the problem of running regression tests in plugins when their references are inside of the plugin and not Regression (e.g. BeamAdapter)
The idea is to have a stand alone
*.regression.tests
file that also includes the relative path of the reference folder. This is meant to be placed at the top of the reference file in a relative manne. This allows two things :Tested on my side : only two remaining regression test failing from SofaSPH
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if