Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Fix subplugin regression tests #4420

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Jan 8, 2024

[ci-depends-on https://github.com/sofa-framework/Regression/pull/56]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/125]

This PR is based on PR #56 of Regression.

This PR fixes the problem of running regression tests in plugins when their references are inside of the plugin and not Regression (e.g. BeamAdapter)

The idea is to have a stand alone *.regression.tests file that also includes the relative path of the reference folder. This is meant to be placed at the top of the reference file in a relative manne. This allows two things :

  1. Having a stand alone file ease the process of finding the reference folder for any new comer
  2. Having a stand alone file ease the process of automatizing the retrieval of new regression test along with their reference folder without the need of modifying anything in the CI script.

Tested on my side : only two remaining regression test failing from SofaSPH


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: dev meeting topic PR to be discussed in sofa-dev meeting labels Jan 8, 2024
@bakpaul
Copy link
Contributor Author

bakpaul commented Jan 8, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Jan 8, 2024

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@bakpaul
Copy link
Contributor Author

bakpaul commented Jan 8, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Jan 8, 2024

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor

Note: we only have regressions for BeamAdapter, Multithreading and SphFluid

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 10, 2024
@bakpaul
Copy link
Contributor Author

bakpaul commented Jan 10, 2024

Create Issue to rethink the way it is done: maybe centralize the regression-tests files in Regression plugin. This would require multiple changes like being able to find the path of all plugins to find the scenes and the regression files when they are inside of the plugin instead of Regression.

--> #4424

@bakpaul bakpaul merged commit 42cc4d4 into sofa-framework:master Jan 10, 2024
19 of 26 checks passed
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
bakpaul added a commit that referenced this pull request Feb 19, 2024
* Add relative path to references files into regression-tests files

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dev meeting topic PR to be discussed in sofa-dev meeting pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants