-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ai fix html #467
feat: ai fix html #467
Conversation
41bbb70
to
9033da5
Compare
9033da5
to
dac65ad
Compare
@@ -1,3 +1,23 @@ | |||
@import '../../common/vscode'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of styling is already in these stylesheets so I imported them .
dac65ad
to
483a7ed
Compare
} | ||
} else { | ||
const lineDiv = document.createElement('div'); | ||
lineDiv.className = 'example-line'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just got all of these scripts from src/snyk/snykCode/views/suggestion/codeSuggestionWebviewScript.ts
, the only thing I changed was the class name so that it matches the existing one used for the example commit fixes.
A lot of these functions are related to switching tabs and rendering different elements. Some of this can be moved to snyk-ls
but it would add a lot of complexity to the task and the review process so I chose to do that in a future ticket/PR. It would be a good task to do when we implement this in IntelliJ too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that we are currently working on the refactor from tabs to arrows for the Community Fixes / Fixed Code Examples
483a7ed
to
eb5c2ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
b21e406
to
ad92d10
Compare
Description
Adds the AI fix panel and some small changes (position line is a link, learn more link has an external icon, background colour matches the old one).
To test, run
npm run build
first before running the extension. It needs snyk/snyk-ls#527 for testing.Checklist
Screenshots / GIFs
The backend isn't working at the moment so for testing I used an org that doesn't have the feature flag enabled and had to change a small part of the code so it's loading the HTML panel:
Screen.Recording.2024-06-07.at.16.52.14.mov