Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store bundle hash for ai fix [IDE-380] #539

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

teodora-sandu
Copy link
Contributor

Description

The vulns get returned with AI fixes but the diffs that get generated from the UI when trying to generate an AI fix wouldn't work. This it because of this line of code:

return unifiedDiffSuggestions, fmt.Errorf("bundle hash not found for baseDir: %s", baseDir)

Added a fix which can be found in the old flow too, where we set the bundle hash on the scanner. Added a test so that next time we change this code we don't forget to set the bundle hash.

To test manually, best to build this version of VSCode: snyk/vscode-extension#467.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

🚨After having merged, please update the CLI go.mod to pull in latest language server.

@teodora-sandu teodora-sandu merged commit 0963926 into main Jun 10, 2024
15 checks passed
@teodora-sandu teodora-sandu deleted the fix/store-bundle-hash-ai-fix branch June 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants