fix: store bundle hash for ai fix

snyk · Jun 10, 2024 · 0b44cc4 · 0b44cc4
1 parent cd4af4f
commit 0b44cc4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/infrastructure/code/code.go b/infrastructure/code/code.go
@@ -409,6 +409,7 @@ func (sc *Scanner) UploadAndAnalyzeWithIgnores(ctx context.Context,
 	if err != nil {
 		return []snyk.Issue{}, err
 	}
+	sc.BundleHashes[path] = bundleHash
 
 	converter := SarifConverter{sarif: *sarif}
 	issues, err = converter.toIssues(path)

diff --git a/infrastructure/code/code_test.go b/infrastructure/code/code_test.go
@@ -397,7 +397,7 @@ func TestUploadAndAnalyzeWithIgnores(t *testing.T) {
 	files := []string{diagnosticUri}
 	fakeCodeScanner := &FakeCodeScannerClient{rootPath: diagnosticUri}
 
-	c := New(
+	sc := New(
 		NewBundler(snykCodeMock, NewCodeInstrumentor()),
 		&snyk_api.FakeApiClient{CodeEnabled: true},
 		newTestCodeErrorReporter(),
@@ -406,7 +406,7 @@ func TestUploadAndAnalyzeWithIgnores(t *testing.T) {
 		notification.NewNotifier(),
 		fakeCodeScanner,
 	)
-	issues, _ := c.UploadAndAnalyzeWithIgnores(context.Background(), "", sliceToChannel(files), map[string]bool{})
+	issues, _ := sc.UploadAndAnalyzeWithIgnores(context.Background(), "", sliceToChannel(files), map[string]bool{})
 	assert.True(t, fakeCodeScanner.UploadAndAnalyzeWasCalled)
 	assert.False(t, issues[0].IsIgnored)
 	assert.Nil(t, issues[0].IgnoreDetails)
@@ -416,6 +416,10 @@ func TestUploadAndAnalyzeWithIgnores(t *testing.T) {
 	assert.Equal(t, "13 days", issues[1].IgnoreDetails.Expiration)
 	assert.Equal(t, 2024, issues[1].IgnoreDetails.IgnoredOn.Year())
 	assert.Equal(t, "Neil M", issues[1].IgnoreDetails.IgnoredBy)
+
+	// verify that bundle hash has been saved
+	assert.Equal(t, 1, len(sc.BundleHashes))
+	assert.Equal(t, snykCodeMock.Options.bundleHash, sc.BundleHashes[path])
 }
 
 func Test_Scan(t *testing.T) {