Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax wording of branch up-to-date in PR template #1705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Relax wording of branch up-to-date in PR template #1705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* [ ] I've added or updated integration tests to verify correctness of my new code.
* [ ] I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
* [ ] I've confirmed that my changes are working by executing CLI's commands manually on Windows.
* [ ] I've confirmed that my changes are up-to-date with the target branch.
* [ ] I've confirmed that my changes are reasonably up-to-date with the target branch.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to ideas about the wording, I just didn't want to be too prescriptive about how long is too long to go without a merge/rebase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this check box exists anyway, since we tend to delay rebasing during the review cycle anyway. This checkbox goes stale almost immediately after the PR is published.

If the intention is to remind devs to always submit the initial PR from the tip of main, then the wording is arguably fine, or we can say something like "I confirm that at the time of publishing the initial review, my changes are up-to-date with the target branch".

* [ ] I've described my changes in the release notes.
* [ ] I've described my changes in the section below.

Expand Down
Loading