Relax wording of branch up-to-date in PR template #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| * [ ] I've added or updated integration tests to verify correctness of my new code. | |||
| * [ ] I've confirmed that my changes are working by executing CLI's commands manually on MacOS. | |||
| * [ ] I've confirmed that my changes are working by executing CLI's commands manually on Windows. | |||
| * [ ] I've confirmed that my changes are up-to-date with the target branch. | |||
| * [ ] I've confirmed that my changes are reasonably up-to-date with the target branch. | |||
There was a problem hiding this comment.
I'm open to ideas about the wording, I just didn't want to be too prescriptive about how long is too long to go without a merge/rebase
There was a problem hiding this comment.
I don't know why this check box exists anyway, since we tend to delay rebasing during the review cycle anyway. This checkbox goes stale almost immediately after the PR is published.
If the intention is to remind devs to always submit the initial PR from the tip of main, then the wording is arguably fine, or we can say something like "I confirm that at the time of publishing the initial review, my changes are up-to-date with the target branch".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
It's no longer a requirement for PRs to be up-to-date when merging, but we still want to remind users to keep their PRs reasonable up to date with the target branch (within about a day or so) to reduce the chance of logical conflicts between two PRs that get merged close to each other.