Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BULK-Updates-2024-06-13 #519

Merged
merged 2 commits into from
Jun 14, 2024
Merged

BULK-Updates-2024-06-13 #519

merged 2 commits into from
Jun 14, 2024

Conversation

LauraB-CWF
Copy link
Collaborator

Updates to crossings incorrectly assigned as 'Passable'

Updates to crossings incorrectly assigned as 'Passable'
@smnorris
Copy link
Owner

Thanks.

I know there are definitely instances in BULK and perhaps other WCRPs where PSCIS barrier status fixes were applied based on the PSCIS comments and were a bit too generous in the interpretation.
But I don't see these two records in the fix table already, that is not the issue here.

PSCIS data indicates these are both habitat confirmations and PSCIS scoring assigns these as passable. PSCIS comments indicate there are other issues going on that are not captured by the scoring - the crossings do need attention/fixes.

I'm fine with switching these to POTENTIAL but for users comparing PSCIS data to bcfishpass data we need to be able to tell why and when the status was changed from what is assigned by PSCIS. Can you adjust the notes values for these?

I'll have to make adjustments to ensure that the notes that describe this change are included in various output tables - crossings_vw, crossings_wcrp_vw and the FPTWG extract - so the casual user can tell why barrier status in PSCIS and bcfishpass do not match. In hindsight, this should already have been done - we already have an extensive list of barrier status adjustments.

@NewGraphEnvironment @CaptainMarmot @nickw-CWF - any comments welcome. Barrier status for a given crossing in bcfishpass may not match PSCIS - even for a habitat confirmation. But going forward something in the crossings views will be added to note why this is the case.

@NewGraphEnvironment
Copy link
Contributor

NewGraphEnvironment commented Jun 13, 2024

seems odd to me to make these changes. The PSCIS metrics were collected somewhat recently using standard protocols and the scores came out passable. There is detailed reporting here https://www.newgraphenvironment.com/fish_passage_bulkley_2020_reporting/appendix-197665-197664-3042-barren-creek.html

crossings were considered passable when assessed. Impacts on fish populations were related to highway maintenance dredging vs passability at that time. We did not have any indication that the railway was being dredged as per the photos or we would have noted that...

Might make sense to reassess and re-enter the data as collected but doing custom alterations in the office to override detailed field assessment data seems like a slippery slope to me...

The detail needed to communicate what is being communicated with these edits (as Simon mentioned - more detail is needed to clarify) - unless I am missing something - IMO belongs outside of bcfishpass. Options could be standalone reporting or perhaps a note in an issue of the repo that builds the report of potential edits that would help clear up some uncertainty.

also just noticed this within this same PR:

197017,PASSABLE,LNIC,LB,2024-04-09,"This is a ford, PSCIS barrier_status = UNKNOWN, edit existing record in fix table to PASSABLE"

There are many thousands of fords and I believe 99.9% of them are all barrier_status = UNKNOWN. I wouldn't think we need to use data/user_pscis_barrier_status.csv to adjust them..... This is already happening in the modelling.

Also - of importance related to the last note - symbolizing fords as "passable" (equivalent to bridges) can be confusing in the field because when surveyors role up on a ford that looks like a bridge on the maps they may think they should reassess it so that bcfishpass and PSCIS has the latest data. This common "unknown" and "passable" symbology used to happen in the past but we rectified that so that now we have a different symbol for the crossing while the modelling recognizes "unknown" as equivalent to "passable"....

@smnorris
Copy link
Owner

I agree that barrier status divergence between bcfishpass and PSCIS should be minimal if any.

This is more of a question for @nickw-CWF @oakoppel-1 - can adjustments to PSCIS status be made in the reporting rather than directly in the bcfishpass crossings table? Or maybe we could apply these changes only in crossings_wcrp_vw for CWF planning use?

There are currently ~1300 PSCIS barrier status adjustments but mostly in WCRP watersheds.

@smnorris
Copy link
Owner

I'm going to merge, this isn't an issue with the PR but with how bcfishpass handles this data generally.

@LauraB-CWF
Copy link
Collaborator Author

LauraB-CWF commented Jun 14, 2024 via email

@smnorris
Copy link
Owner

Thanks @LauraB-CWF ! That all sounds good and your updates work well for what the WCRP team needs.

The remaining issue is more of a general bcfishpass usage/architecture question that is not hard to resolve - but will take a bit of work on my end. Discussion on that can move over to #521

@smnorris smnorris merged commit 38caaf4 into main Jun 14, 2024
4 checks passed
smnorris added a commit that referenced this pull request Jun 14, 2024
* main:
  BULK-Updates-2024-06-13 (#519)
  BULK-Updates-2024-06-06 (#509)
  LNIC-Updates-2024-06-11 (#514)
  tweak cw threshold description (#512)
@smnorris smnorris deleted the BULK-Updates-2024-06-13 branch June 15, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants