Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KS-347] Start tracking registerTrigger goroutine #13688

Merged
merged 7 commits into from
Jun 27, 2024
Merged

[KS-347] Start tracking registerTrigger goroutine #13688

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6679dd4
[KS-347] Start tracking registerTrigger goroutine
cedric-cordenier Jun 25, 2024
b1db7c4
Merge branch 'develop' into register-trigger-untracked
cedric-cordenier Jun 25, 2024
a5d0293
Merge branch 'develop' into register-trigger-untracked
bolekk Jun 26, 2024
5494d8d
Check for channel closed
cedric-cordenier Jun 27, 2024
d61fe45
Merge branch 'develop' into register-trigger-untracked
cedric-cordenier Jun 27, 2024
e577513
Check for channel closed
cedric-cordenier Jun 27, 2024
81c6486
Merge branch 'develop' into register-trigger-untracked
cedric-cordenier Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/services/workflows/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,17 @@ func (e *Engine) registerTrigger(ctx context.Context, t *triggerCapability, trig
}}
}

e.wg.Add(1)
go func() {
for event := range eventsCh {
e.triggerEvents <- event
defer e.wg.Done()

for {
select {
case <-e.stopCh:
return
case event := <-eventsCh:
e.triggerEvents <- event
}
}
}()

Expand Down
Loading