Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KS-347] Start tracking registerTrigger goroutine #13688

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

cedric-cordenier
Copy link
Contributor

  • previously the registerTrigger goroutine was untracked; this adds it to the engine wait group and ensures that we'll wait for all such routines to shut down before the engine does.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cedric-cordenier cedric-cordenier marked this pull request as ready for review June 25, 2024 18:36
@cedric-cordenier cedric-cordenier requested a review from a team as a code owner June 25, 2024 18:36
jmank88
jmank88 previously approved these changes Jun 25, 2024
HenryNguyen5
HenryNguyen5 previously approved these changes Jun 25, 2024
krehermann
krehermann previously approved these changes Jun 25, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@bolekk bolekk added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@bolekk bolekk added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 27, 2024
Merged via the queue into develop with commit 7a3ba8e Jun 27, 2024
112 of 113 checks passed
@cedric-cordenier cedric-cordenier deleted the register-trigger-untracked branch June 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants