simplify HealthReport() implementations #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
requested review from
samsondav,
sdrug,
martin-cll,
connorwstein,
archseer,
cfal,
reductionista,
prashantkumar1982 and
a team
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
force-pushed
the
simpler-health-report
branch
from
9546ab5 to
9a3cc45
Compare
jmank88
force-pushed
the
simpler-health-report
branch
from
9a3cc45 to
38c5f0e
Compare
|
SonarQube Quality Gate
|
essamhassan
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify/align many implementations of
HealthReport(), fixcosmos/chain.chainandevm/gas.arbitrumEstimator, which were not chaining properly.