Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/services: services helper #10697

Closed
wants to merge 3 commits into from
Closed

core/services: services helper #10697

wants to merge 3 commits into from

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Sep 19, 2023 •
edited
Loading

Still hacking on this, and now wondering if it should be in chainlink-relay 🤔

@jmank88 jmank88 added the wip label Sep 19, 2023
@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@jmank88 jmank88 mentioned this pull request Sep 19, 2023
Merged
@patrickhuie19
Copy link
Contributor

Mind explaining why you think this could fit better into chainlink-relay?

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 19, 2023

Mind explaining why you think this could fit better into chainlink-relay?

To be importable by the chain relayers and product repos.

jmank88
jmank88 commented Sep 20, 2023
View reviewed changes
core/services/service.go Outdated Show resolved Hide resolved
@jmank88
Copy link
Contributor Author

jmank88 commented Oct 3, 2023

I overlooked the SvcErrBuffer ErrorBuffer when doing the last pass, so this may be off track at the moment.

@jmank88 jmank88 force-pushed the services-helpers branch 4 times, most recently from d8a49e2 to eff912c Compare October 4, 2023 23:35
@jmank88
Copy link
Contributor Author

jmank88 commented Oct 4, 2023

Requires:

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jmank88
Copy link
Contributor Author

jmank88 commented Oct 29, 2023

Moved to smartcontractkit/chainlink-common#204

@jmank88 jmank88 closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @patrickhuie19