BCF-2637 Add evm chain id removal migrations #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
reviewed
Sep 16, 2023
core/store/migrate/migrations/0195_add_evm_chain_id_to_job_specs.go
Outdated
Show resolved
Hide resolved
core/store/migrate/migrations/0195_add_evm_chain_id_to_job_specs.go
Outdated
Show resolved
Hide resolved
jmank88
previously approved these changes
Sep 16, 2023
samsondav
requested changes
Sep 18, 2023
core/store/migrate/migrations/0195_add_evm_chain_id_to_job_specs.go
Outdated
Show resolved
Hide resolved
samsondav
approved these changes
Sep 18, 2023
jmank88
approved these changes
Sep 18, 2023
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added evm chain id not null migrations and helper function to be run pre migration to insert all evm chain ids.
This is done because injecting config(that is needed to know chain id) into migrations is a nightmare, so we use helper code that will be removed in the next node version