BCF-2637 Change evmChainID not null migration to use env var to inject goose #10711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
requested review from
jkongie,
jmank88 and
samsondav
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
reviewed
Sep 20, 2023
core/store/migrate/migrations/0195_add_not_null_to_evm_chain_id_in_job_specs.go
Show resolved
Hide resolved
jmank88
reviewed
Sep 20, 2023
core/store/migrate/migrations/0195_add_not_null_to_evm_chain_id_in_job_specs.go
Outdated
Show resolved
Hide resolved
…hain-id-removal-helper' into BCF-2637-change-migrations-evm-chain-id-removal-helper
jmank88
previously approved these changes
Sep 20, 2023
…hain-id-removal-helper' into BCF-2637-change-migrations-evm-chain-id-removal-helper
jmank88
previously approved these changes
Sep 21, 2023
|
SonarQube Quality Gate
|
jmank88
approved these changes
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jmank88
deleted the
BCF-2637-change-migrations-evm-chain-id-removal-helper
branch
ilija42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach on how to run this migration, where we inject chain id value into env var that is then retrieved in goose migration. First approach was to run helper functions before migrations that inserted chain ids into specs.