-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for Coffeescript 2 (and hubot 3) #565
Add compatibility for Coffeescript 2 (and hubot 3) #565
Conversation
Add COFFEESCRIPT_VERSION variable to env of .travis.yml
Tests are failed on nodejs <= 5 with envs are Test failed detail
|
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 85.19% 85.42% +0.22%
==========================================
Files 6 6
Lines 385 391 +6
Branches 84 84
==========================================
+ Hits 328 334 +6
Misses 34 34
Partials 23 23
Continue to review full report at Codecov.
|
eb09c00
to
46407de
Compare
@aoberoi Any chance we could get your review here? This would be really useful for me. |
@phucnh @aoberoi @stevengill @shaydewael |
I've reverted this PR as it's not fully compatible with CoffeeScript 2 yet. I'm still positive to support CoffeeScript v2 in future versions but for the next minor version (v4.8.0 - https://github.com/slackapi/hubot-slack/milestone/4), this improvement may be out of scope. |
Summary
This PR continues #528 works.
Make sure the classes in this code work in Coffeescript 2 (and with hubot 3).
A few of the semantic differences between Coffeescript 1 classes and ES2015 classes has introduced some backwards compatibility issues, as follows:
Breaking Changes From CoffeeScript 1.x to 2
Known Issue: This PR doesn't make hubot-slack work with hubot 2 in Coffeescript 2. Because hubot 2 still based on Coffeescript 1.
Refs: #526
Requirements (place an
x
in each[ ]
)