WIP: add compatibility for Coffeescript 2 #528
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts the work on making sure the classes in this code work in Coffeescript 2. As mentioned previously, a few of the semantic differences between Coffeescript 1 classes and ES2015 classes has introduced some backwards compatibility issues, documented here: https://coffeescript.org/#breaking-changes
Currently, this mostly works, but trying to actually launch Hubot fails with a
TypeError: Cannot read property 'bind' of undefined
error. I believe this may be because of the following:refs #526.
Requirements (place an
x
in each[ ]
)