Support for Python 3 and Django 1.9+ (plus Tox) #26
Conversation
This ensures that Django is actually an installation requirement, and allows Tox to run the tests with varying versions of Django more easily.
Users of this library may be running other versions of it.
This should get the test suite passing on Python 3 / Django 1.8.
This means that the output is no longer left unescaped by default, and an explicit mark_safe() is required to leave the seo_js_head tag's HTML markup intact in Django 1.9+. Further reading: https://www.djangoproject.com/weblog/2015/jun/29/simple_tag-security- advisory/ https://docs.djangoproject.com/en/stable/releases/1.9/#simple-tag- conditional-escape-fix
Django 1.10 no longer supports the old TEMPLATE_* settings.
|
What is stopping this from being merge? I need python 3 and django 1.8 support :( |
|
@skoczen Whats up on this ? |
|
Let me see if I can get in touch with someone. Sorry for the delay here! |
|
Hey @Anton-Shutik and @thoop @pjdelport @LRPalacios thanks for your patience - the delay has been moving to a new country, switching jobs, and basically all of life being upside down. I haven't had time to test any of the proposed changes, but if I can get a thumbs up from folks who have tested this and see that it's working, I'll just do a release blind to unblock folks. Please let me know, and thanks for hanging in there! |
|
Wondering if this is still planned to go in. Cheers! |
|
@skoczen if you're up for it, you can add another collaborator (me, or anyone here who's up for it). Basically:
With that someone else can merge PRs and create releases. I added some updates in a new PR since it didn't work for me on Django 2, and pulled in changes from other forks that I found useful: #30. |
|
Quick reply - definitely up to add a collaborator. Slammed right now, but will hopefully get this done next week! Thanks for your patience! |
|
also, please add .base to import |
|
@skoczen I'm available and looking to take on more open source project management experience. I'll contact you directly to ensure you see this ;) |
|
I'm up to be added as a reviewer/collaborator as well. I think prerender released some updates for Google's changes in July, not sure if we need anything there but @derek-adair if you have time, take a look! I contacted them since I set it up for a client, and will follow up if they suggest anything.
|
|
This project may also be a good candidate for Jazzband? |
|
WTF jazzband is awsome!! I'd love to get involved. I ended up having to take over burntsushi/nflgame because of burnout. Currently convincing the author to let me take over the pypi namespace but he's understandibly reluctant so i've taken it upon myself to make a redux fork |
|
@skoczen any updates here? |
|
Update - things are moving forward without me being in the way. Please see #32 for our next steps in this project, and thank you so much for your contributions, and for your patience. :) Ping: @guykogel @derek-adair @pjdelport @pcraciunoiu @mkaliberda @jjwon0 @thoop @Anton-Shutik @Luis-Palacios |
|
If anyone wants to update this, I'd be happy to review and help merge. |
|
@pcraciunoiu: I reviewed, and it looks like PR #30 supersedes this. Thanks! |
This makes the test suite pass on 2.7 + 3.5, and Django 1.8 – 1.10.
This also adds a Tox configuration that will test all combinations of the above.