Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the requests dependency pinned? #27

Closed
PiDelport opened this issue Oct 5, 2016 · 3 comments · Fixed by #33
Closed

Why is the requests dependency pinned? #27

PiDelport opened this issue Oct 5, 2016 · 3 comments · Fixed by #33

Comments

@PiDelport
Copy link
Collaborator

Currently, this library pins requests to requests==2.2.1.

Is there a reason for this? If not, this should be loosened to just requests: it's not a good idea for a library to pin versions that might conflict with downstream projects' requirements.

@PiDelport PiDelport changed the title Why is requests dependency pinned? Why is the requests dependency pinned? Oct 5, 2016
@PiDelport
Copy link
Collaborator Author

Note that PR #26 un-pins this, and it seems to work okay.

@derek-adair
Copy link

derek-adair commented Nov 17, 2016

Hey just a heads up @skoczen is pretty busy at the moment and isn't very active on github any longer. I'm sure he'd be interested in receiving some help maintaining this project as it seems you have your head wrapped around it already you might think about reaching out to him (his email is listed on his profile)

@PiDelport
Copy link
Collaborator Author

I don't quite have the bandwidth to take on maintenance of this project right now either, unfortunately. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants