Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter warnings in the Disctributor #1112

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Fix linter warnings in the Disctributor #1112

merged 6 commits into from
Aug 29, 2024

Conversation

DimaStebaev
Copy link
Contributor

@DimaStebaev DimaStebaev commented Aug 28, 2024 •
edited
Loading

  • update solidity
  • fix imports-order
  • fix named-parameters-mapping
  • fix gas-custom-errors

@DimaStebaev DimaStebaev linked an issue Aug 28, 2024 that may be closed by this pull request
Calculate rewards up to 10 years by 1 "withdrawBounty" #925
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.01%. Comparing base (e620fb0) to head (2ac3295).

Files with missing lines Patch % Lines
contracts/delegation/Distributor.sol 85.71% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           v1.12.0    #1112      +/-   ##
===========================================
- Coverage    94.07%   94.01%   -0.06%     
===========================================
  Files           40       40              
  Lines         2985     2991       +6     
  Branches       691      691              
===========================================
+ Hits          2808     2812       +4     
- Misses         177      179       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimaStebaev DimaStebaev marked this pull request as ready for review August 28, 2024 14:03
@DimaStebaev DimaStebaev merged commit c37197e into v1.12.0 Aug 29, 2024
6 of 8 checks passed
@DimaStebaev DimaStebaev deleted the linter branch August 29, 2024 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@payvint payvint Awaiting requested review from payvint payvint is a code owner

@yavrsky yavrsky Awaiting requested review from yavrsky yavrsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculate rewards up to 10 years by 1 "withdrawBounty"
2 participants
@DimaStebaev @DmytroNazarenko