Calculate rewards up to 10 years by 1 "withdrawBounty"

[payvint]

Current problem

There is a limit in Distributor contract that you can claim bounty for 12 months max. And if you delegated 25 months ago, and want to claim rewards - you need to call withdrawBounty 3 times(12 + 12 + 1). This limit was introduce by high gas consumption of function "withdrawBounty" - by 12 months to would cost 810K of gas. And right now on all platforms (Activate, Delegation Portal, Skale Analytics) claimable reward shows only by 12 months which make clients confused of small amount. Results provided by call "getAndUpdateEarnedBountyAmountOf".

Solution

It would be good to increase a limit by 10 years(120 months) or higher, gas consumption would be 8M of gas(which still fit in block gas limit 30M). It would show correct amount of claimable rewards for the 10 year period.
10 year - 8M gas
30 year - 24M gas

[payvint]

I would say increase up to 30 year - would make more sense till if fits in the block gas limit

[DimaStebaev]

The fix is a matter of changing a 1 constant in a 1 contract.

[yatsunastya]

Version: 1.12.0-beta.2

For validators earned fees calculation is still 12 months.
Code reference

[yatsunastya]

Checked bounty calculation for a holder.
Version: 1.12.0-beta.2

withdrawBounty transaction on 1.11.0 version. There are bounties for ~ 2.5 years, but it was withdrawn for 12 months.

withdrawBounty transaction on 1.12.0-beta.2 version. There are bounties for ~ 3.5 years and it was withdrawn for ~ 42 months.

[yatsunastya]

Checked ✅
Version: 1.12.0-beta.4

withdrawFee transaction. There are fees for ~ 42 months.