Staking UI - escrow, grants, delegation actions and summary #205
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dmytrotkk
changed the title
| export default function Delegate(props: { | ||
| mpc: MetaportCore | ||
| validator: IValidator | undefined | ||
| si: StakingInfoMap |
There was a problem hiding this comment.
Suggest full name for easier updates in the future
| async function stake() { | ||
| setLoading(true) | ||
| try { | ||
| console.log(`Delegating SKL...`) |
There was a problem hiding this comment.
Should debug log only
There was a problem hiding this comment.
replaced with log()
| 'delegation' | ||
| ) | ||
| const res = await sendTransaction(delegationContract.delegate, [ | ||
| props.validator?.id, |
There was a problem hiding this comment.
Should this be left nullable? Maybe better to handle potential null value above and inform user accordingly
There was a problem hiding this comment.
handled missed validator
| export default function DelegationTypeSelect(props: { | ||
| delegationType: DelegationType | ||
| handleChange: (event: any) => void | ||
| si: StakingInfoMap |
There was a problem hiding this comment.
Suggest potentially making si full variable name to improve readiablity later
| </p> | ||
| </div> | ||
| ) : null} | ||
| {/* <div className={cls(cmn.flexg)}></div> */} |
src/pages/StakeAmount.tsx
Outdated
| // if (!currentValidator) { | ||
| // return <Loader text="Loading validator info" /> | ||
| // } | ||
|
|
||
| // if (loaded && !available) { | ||
| // return <div> | ||
| // <Container maxWidth="md"> | ||
| // <ErrorTile errorMsg="Delegation type is not available" setErrorMsg={setErrorMsg} /> | ||
| // </Container> | ||
| // </div> | ||
| // } |
There was a problem hiding this comment.
Please, remove commented code
src/core/interfaces/Delegator.ts
Outdated
| // export interface IDelegatorInfo { | ||
| // balance: bigint | ||
| // staked: bigint | ||
| // rewards: bigint | ||
| // } |
There was a problem hiding this comment.
Please, remove commented code
src/core/delegation/validators.ts
Outdated
| // if (ESCROW_VALIDATORS.includes(a.id) !== ESCROW_VALIDATORS.includes(b.id)) { | ||
| // return a.acceptNewRequests ? -1 : 1 | ||
| // } |
There was a problem hiding this comment.
Please, remove commented code
This PR includes:
skale-contractslibrary integration for all staking-related contract interactionsmetaportlibrary with improved transaction handling and additional wallet supportMainnet preview can be found on Vercel.
Tested manually on Testnet and Mainnet contracts, since there are no automated tests for
portalrepo.No performance changes.