Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket 737, switch IMA agent to to ethers.js in branch v1.6.0 #1452
Ticket 737, switch IMA agent to to ethers.js in branch v1.6.0 #1452
Changes from all commits
91d7d5d
e8279ba
86439eb
82081aa
b063f82
fa4baa8
a3dc4d7
62f33f7
fa4e2eb
4a1503a
827196e
9bdadf2
e52529a
a069fd9
9aab34b
43f5b56
ec1ba48
01d3d6f
08487c6
7d28cdb
6b258a4
3af0865
8210fed
397bb52
f16bb4e
4e6470e
9c45a0b
ec7c462
4b7f510
6795530
94b61ef
c1e8b3c
06dd3db
09aa0db
c67ddec
e2b224b
e5e9547
fb5f83f
fa45069
1d54c4f
2496b3b
1a3caf7
35a5fe6
c44275f
5c3b116
d94ff2f
64c474f
729be43
1b3ea94
1466eba
92c71e2
63da318
e2c0577
057f783
d00c009
cbc0bdc
bf5a61a
e33a8c6
e818e40
ae965aa
6f11854
280dc37
6e12ee9
1eb98d9
b5ab32c
4bf94ea
18b2b6f
2228e49
356a97c
29a9adf
4efe3e1
44c2c4f
d295e51
2d4aa63
9f0ad92
b9ad5fc
862c822
52581b7
8dc5c83
a7dafdd
eb4c315
d073b80
399c2d7
a5c0769
716cae4
c3c1809
e1d4dcc
4d3ec7b
d2470c6
f00db01
7e2571f
828306d
6e6ce4a
538c4b2
9168295
966257a
c8cc363
d0dea88
b909bf8
6c7a955
b303a13
3fc7e0b
61f3d2d
1e1d70c
bbe5309
05edb84
f8f8ed8
12be5eb
67211b3
ea314ee
a7405ab
277ba12
54af24b
9fcb63f
405d593
18818d4
0eaf7d2
55384dc
59e516e
3032583
1b8b1bf
a98f832
e7916c9
f122c1f
e615e2a
58f0081
daf9711
279d37e
f9213eb
2364fd2
7a153fa
97f7dc2
d26babc
f1e9669
fae0d73
93cf594
8b3bd32
3a3c2f9
f77ede7
d2244db
f54932f
aecae84
8394850
04b4547
749960b
7391a63
68e0fb1
414cb07
8f5657e
c3468b8
b3c05e1
7ec0031
0242f88
96c90f3
1550d2a
aa77a2e
1651236
173c062
49a0b4e
76a50f7
b95c226
c24f840
35b1545
e6a9aba
febd9e5
de9b961
f96f82f
4462b64
2e74669
f41319d
e6825f5
a3cc8ce
6c6858f
6fc3c29
6170b3d
41c706b
b09ca18
0d3f257
4cab083
dba4417
ea5f438
3fcb2ae
1733f72
ae3dd62
be7d6ef
4432f62
03f4fd7
3a38ddd
9e1d4ca
0765278
6baa696
48da1b0
3316705
41ebcd0
5471298
a2c8bc9
e8a0fc4
bbf9bba
f4dc0e9
c5e24e6
84692fd
69b3b73
80fc4a5
b340be2
ef1ee64
db6effb
f352b51
076b35f
53d6bd9
2536738
eb677f6
0a49dea
954e00b
3f3f11f
eeceb3b
eb1b5f9
3da3e40
e589338
e303d43
c53e5cf
af4bb04
d909a2b
33899a7
7da0290
16694d6
076ffe9
21caba4
fe6ace4
376b22e
53f48ed
58c4cb5
f9c6e11
b8355fd
691da5d
a8b8490
40ded9b
6958046
f2e680a
c043768
e36a6b2
0701277
81f853a
db33d3e
cfe43fa
40c8496
1ed7f8b
bc59ff4
72055ac
842d738
7fa90c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to guidelines it is reasonable to set max lines per func = 100: https://github.com/skalenetwork/internal-support/blob/main/docs/wiki/code-guidelines.md#function-length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 200 again))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I see it's still 100.