Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket 737, switch IMA agent to to ethers.js in branch v1.6.0 #1452

Merged
merged 328 commits into from
Jun 2, 2023
Merged

Ticket 737, switch IMA agent to to ethers.js in branch v1.6.0 #1452

merged 328 commits into from
Jun 2, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

@sergiy-skalelabs sergiy-skalelabs commented Feb 27, 2023 •
edited
Loading

  • IMA Agent was re-written 90% from scratch and now based on ethers.js
  • All JavaScript code is ES6 now, so all files are *.mjs
  • Fixed OKR requirements, all JS lines of code are limited to 100 characters, all JS functions are limited to 200 lines of code including empty lines, everything named camelCase everywhere it was possible, massive source code cleanup
  • Fixed documentation missmprints and errors, updated documentation with descriptions of changed command line options
  • Fixed PY tests run issues on fast local computers
  • Fixed JS tests errors running on local computers
  • Cleaned up docker file and github action scripts
  • Improved IMA Agent logging filters, all logging messages correspond to appropriate --verbose=0..9 level
  • Fixed all codacy issues and warnings, codacy report is completely clean green now

yavrsky and others added 30 commits January 11, 2023 03:20
@yavrsky
Fix linter
91d7d5d
@yavrsky
Fix build
e8279ba
@yavrsky
Fix build
86439eb
@sergiy-skalelabs
ticket-737 - first full .mjs version of code, everything possible is …
82081aa 
…ES6 modules now
@sergiy-skalelabs
ticket-737 - deps fixes
b063f82
@sergiy-skalelabs
ticket-737 deps fixes
fa4baa8
@sergiy-skalelabs
ticket-737 moving away from web3.js, moving closer to ethers.js
a3dc4d7
@sergiy-skalelabs
ticket-737 moving away from web3.js, moving closer to ethers.js
62f33f7
@sergiy-skalelabs
ticket-1413 SNB does multiple attempts to download S-Chain descriptions
fa4e2eb
@sergiy-skalelabs
ticket-1413 SNB does multiple attempts to download S-Chain descriptions
4a1503a
@sergiy-skalelabs
ticket-1413 SNB does multiple attempts to download S-Chain descriptions
827196e
@sergiy-skalelabs
ticket-263 Specification for SNB
9bdadf2
@sergiy-skalelabs
Merge remote-tracking branch 'origin/develop' into ticket-737/IMA-swi…
e52529a 
…tch-toethers-js
@sergiy-skalelabs
ticket-737 transient commit
a069fd9
@sergiy-skalelabs
ticket-737 transient commit
9aab34b
@sergiy-skalelabs
ticket-737 transient commit
43f5b56
@sergiy-skalelabs
ticket-737 transient commit
ec1ba48
@sergiy-skalelabs
ticket-737 transient commit
01d3d6f
@sergiy-skalelabs
ticket-737 transient commit
08487c6
@sergiy-skalelabs
ticket-737 transient commit
7d28cdb
@sergiy-skalelabs
ticket-737 transient commit
6b258a4
@sergiy-skalelabs
ticket-737 transient commit
3af0865
@sergiy-skalelabs
ticket-737 transient commit
8210fed
@sergiy-skalelabs
ticket-737 transient commit
397bb52
@sergiy-skalelabs
ticket-737 fixes for ES6 support in global variables management
f16bb4e
@sergiy-skalelabs
ticket-737 fixes for ES6 support everywhere
4e6470e
@sergiy-skalelabs
ticket-737 fixes for ES6 support everywhere
9c45a0b
@sergiy-skalelabs
ticket-737 fixes for SGX BLS signing support everywhere
ec7c462
@sergiy-skalelabs
ticket-737 fixes for SGX BLS signing support everywhere
4b7f510
@sergiy-skalelabs
ticket-737 fixes for SGX BLS signing support everywhere
6795530
payvint
payvint reviewed May 26, 2023
View reviewed changes
npms/skale-ima/index.mjs Outdated Show resolved Hide resolved
@payvint payvint self-requested a review May 26, 2023 11:39
payvint
payvint reviewed May 26, 2023
View reviewed changes
Copy link
Collaborator

@payvint payvint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!
Just to fix some small items!

yavrsky and others added 9 commits May 29, 2023 14:09
@yavrsky
Merge pull request #1397 from skalenetwork/1396-add-support-for-the-l…
e36a6b2 
…atest-version-of-upgrade-tools

1396 add support for the latest version of upgrade tools
@sergiy-skalelabs
ticket-1453 - Improve IMA integration tests
0701277
@sergiy-skalelabs
Merge remote-tracking branch 'origin/ticket-737/IMA-switch-toethers-j…
81f853a 
…s' into ticket-737/IMA-switch-toethers-js-v1.6.0
@sergiy-skalelabs
Merge branch 'develop' into ticket-737/IMA-switch-toethers-js
db33d3e
@sergiy-skalelabs
ticket-1453 - Improve multi-call implementation in IMA Agent
cfe43fa
@sergiy-skalelabs
Merge remote-tracking branch 'origin/ticket-737/IMA-switch-toethers-j…
40c8496 
…s' into ticket-737/IMA-switch-toethers-js-v1.6.0
@DimaStebaev
Switch geth to PoA mode
1ed7f8b
@sergiy-skalelabs
Merge remote-tracking branch 'origin/ticket-737/IMA-switch-toethers-j…
bc59ff4 
…s' into ticket-737/IMA-switch-toethers-js-v1.6.0
@sergiy-skalelabs
codacy fix
72055ac
DimaStebaev
DimaStebaev previously approved these changes Jun 1, 2023
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@payvint payvint self-requested a review June 2, 2023 18:54
payvint
payvint approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@payvint payvint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

@sergiy-skalelabs sergiy-skalelabs merged commit c636314 into v1.6.0 Jun 2, 2023
@sergiy-skalelabs sergiy-skalelabs deleted the ticket-737/IMA-switch-toethers-js-v1.6.0 branch June 2, 2023 21:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
This was linked to issues Jun 9, 2023
Refactor source code of IMA Agent to follow Code Guidelines #1478
Closed
IMA Verify and Sign not work in parallel #1405
Closed
IMA frames stop work after some time #1407
Closed
IMA agent JS only #1248
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@payvint payvint payvint approved these changes

@cstrangedk cstrangedk cstrangedk approved these changes

@DimaStebaev DimaStebaev DimaStebaev approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko left review comments

@kladkogex kladkogex kladkogex left review comments

@PolinaKiporenko PolinaKiporenko Awaiting requested review from PolinaKiporenko

Assignees

@sergiy-skalelabs sergiy-skalelabs

Labels
IMA
Projects
None yet
Milestone
v1.6.0
7 participants
@sergiy-skalelabs @DimaStebaev @cstrangedk @kladkogex @payvint @DmytroNazarenko @yavrsky