Fix BackURL redirect with strict or lax session cookie security. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #55 PR for more context. This is merely a cherry pick / copy of that commit but for the 2 branch so in theory should work in SS 4.x
|
Testing this in a proper environment that has SAML oauth to see if this fixes missing cookies #nomnomnom. |
|
Tested the RelayState and it works perfecto. |
|
How urgent do you need this? |
Not super urgent but will be finished on client project by Friday. But it can live on the dev branch for now i guess. |
satrun77
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #55 PR for more context.
This is merely a cherry pick / copy of that commit but for the 2 branch so in theory should work in SS 4.x