Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both CMS 4 and CMS 5 installs #61

Closed
NightJar opened this issue Apr 14, 2024 · 1 comment
Closed

Allow both CMS 4 and CMS 5 installs #61

NightJar opened this issue Apr 14, 2024 · 1 comment

Comments

@NightJar
Copy link
Contributor

The upgrade from CMS 4 to CMS 5 support involved a single number change in composer.json. I propose this should have been ^4 || ^5 instead.

There is no dependency difference between the two branches (no API change was needed for CMS 5 support), and fixes from the main branch are having to be "backported" (#58 & #59) to the CMS 4 branch, where rebase "merging" has occurred - diverging the commit history. This likely makes the normal "merge-up" routine more difficult.

Simplifying maintainer support by changing the framework requirement (and probably removing the CMS requirement too - no code relies on it) would make things easier for everyone until such time that an actual codebase deviation is required for multiple version support.

@NightJar
Copy link
Contributor Author

CMS 4 is end of life in just a few months.
It's too late for this now. The 2 branch can be end of life too in time with the CMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant