MNT Remove TODO comments #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 11, 2023
| @@ -1,8 +1,5 @@ | |||
| import jQuery from 'jquery'; | |||
|
|
|||
| /** | |||
| * @todo Re-validate this with Subsites | |||
| */ | |||
There was a problem hiding this comment.
I think it's no longer actual issue
sabina-talipova
commented
Oct 11, 2023
There was a problem hiding this comment.
Open ticket: #214
sabina-talipova
commented
Oct 11, 2023
| @@ -4,8 +4,6 @@ | |||
|
|
|||
| use SilverStripe\Dev\FunctionalTest; | |||
| use SilverStripe\CMS\Model\SiteTree; | |||
| // @todo add translatable namespace | |||
| use Translatable; | |||
There was a problem hiding this comment.
Related to this issue: silverstripe/silverstripe-framework#10548
GuySartorelli
requested changes
Oct 19, 2023
sabina-talipova
force-pushed
the
pulls/5.1/remove-todo
branch
from
56fe3fd to
0b39764
Compare
sabina-talipova
force-pushed
the
pulls/5.1/remove-todo
branch
from
0b39764 to
c37f618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue