Skip to content

Commit

Permalink
MNT Remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sabina Talipova committed Oct 11, 2023
1 parent a7e77a6 commit 56fe3fd
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 31 deletions.
3 changes: 0 additions & 3 deletions client/src/bundles/PagesDueForReview.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import jQuery from 'jquery';

/**
* @todo Re-validate this with Subsites
*/
jQuery.entwine('ss', ($) => {
// Hide all owner dropdowns except the one for the current subsite
function showCorrectSubsiteIDDropdown(value) {
Expand Down
4 changes: 0 additions & 4 deletions src/Extensions/ContentReviewCMSExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,6 @@ protected function findRecord($data)
* Check if the current request has a X-Formschema-Request header set.
* Used by conditional logic that responds to validation results
*
* @todo Remove duplication. See https://github.com/silverstripe/silverstripe-admin/issues/240
*
* @return bool
*/
protected function getSchemaRequested()
Expand All @@ -142,8 +140,6 @@ protected function getSchemaRequested()
/**
* Generate schema for the given form based on the X-Formschema-Request header value
*
* @todo Remove duplication. See https://github.com/silverstripe/silverstripe-admin/issues/240
*
* @param string $schemaID ID for this schema. Required.
* @param Form $form Required for 'state' or 'schema' response
* @param ValidationResult $errors Required for 'error' response
Expand Down
24 changes: 0 additions & 24 deletions tests/php/ContentReviewBaseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

use SilverStripe\Dev\FunctionalTest;
use SilverStripe\CMS\Model\SiteTree;
// @todo add translatable namespace
use Translatable;

/**
* Extend this class when writing unit tests which are compatible with other modules.
Expand All @@ -21,32 +19,10 @@ abstract class ContentReviewBaseTest extends FunctionalTest
protected function setUp(): void
{
parent::setUp();

/*
* We set the locale for pages explicitly, because if we don't, then we get into a situation
* where the page takes on the tester's (your) locale, and any calls to simulate subsequent requests
* (e.g. $this->post()) do not seem to get passed the tester's locale,
* but instead fallback to the default locale.
*
* So we set the pages locale to be the default locale, which will then match any subsequent requests.
*
* If creating pages in your unit tests (rather than reading from the fixtures file), you must explicitly call
* self::compat() on the page, for the same reasons as above.
*/
if (class_exists(Translatable::class)) {
$this->translatableEnabledBefore = SiteTree::has_extension(Translatable::class);
SiteTree::remove_extension(Translatable::class);
}
}

protected function tearDown(): void
{
if (class_exists(Translatable::class)) {
if ($this->translatableEnabledBefore) {
SiteTree::add_extension(Translatable::class);
}
}

parent::tearDown();
}
}

0 comments on commit 56fe3fd

Please sign in to comment.