-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Remove TODO comments #129
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,6 @@ | |
use SilverStripe\Forms\Form; | ||
use SilverStripe\View\Requirements; | ||
|
||
/** | ||
* @todo rename file to match class name | ||
* @todo investigate updated HTMLEditorField_Toolbar changes, and find new implementation | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open ticket: #127 |
||
class CustomHtmlEditorFieldToolbar extends Extension | ||
{ | ||
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LoginAttemptNotifications extension is currently disabled. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,6 @@ | |
use SilverStripe\View\Requirements; | ||
|
||
/** | ||
* TODO: describe. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open ticket: #127 |
||
* TODO: bug when using default admin - always shows the message... | ||
* Requires Security::login_recording config to be set to true. | ||
* | ||
* @property LeftAndMain $owner | ||
|
@@ -69,14 +67,12 @@ public function init() | |
|
||
$message .= "The attempts were from " . implode(', ', $IPs) . '. '; | ||
|
||
// TODO: add this call to action in a way that doesn't break out of the availabel space. Fix CSS? | ||
// $message .= "If you suspect somebody else might be trying to access | ||
// . "your account, please contact support."; | ||
$message .= "If you suspect somebody else might be trying to access " | ||
. "your account, please contact support."; | ||
} | ||
} | ||
} else { | ||
// New session - show last login attempt. | ||
// TODO: this currently does NOT surface to the frontend in any way. | ||
$lastLoginAttempt = LoginAttempt::get()->filter([ | ||
'MemberID' => $member->ID | ||
])->sort('Created DESC')->First(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,6 @@ | |
* CwpAtomFeed class | ||
* | ||
* This class is used to create an Atom feed. | ||
* @todo Improve documentation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open ticket: #127 |
||
* @package cwp-core | ||
*/ | ||
use SilverStripe\Control\Controller; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open ticket: #128