Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #129

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions _config/extensions.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
---
Name: cwpcoreextensions
---
# @todo Disable the feature. LoginAttempt seems to be broken on bridging solution - logs every
# request instead of logins!
# Follow up issue: https://github.com/silverstripe/cwp-core/issues/41
# SilverStripe\Admin\LeftAndMain:
# extensions:
# - CWP\Core\Extension\LoginAttemptNotifications

SilverStripe\ORM\FieldType\DBField:
extensions:
Expand All @@ -16,7 +10,6 @@ SilverStripe\Security\Group:
extensions:
- CWP\Core\Extension\CwpHtmlEditorConfig

# @todo investigate replacement for this
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #128

HtmlEditorField_Toolbar:
extensions:
- CWP\Core\Extension\CustomHtmlEditorFieldToolbar
4 changes: 0 additions & 4 deletions src/Extension/CustomHtmlEditorField.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
use SilverStripe\Forms\Form;
use SilverStripe\View\Requirements;

/**
* @todo rename file to match class name
* @todo investigate updated HTMLEditorField_Toolbar changes, and find new implementation
*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #127

class CustomHtmlEditorFieldToolbar extends Extension
{

Expand Down
8 changes: 2 additions & 6 deletions src/Extension/LoginAttemptNotifications.php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoginAttemptNotifications extension is currently disabled.

Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
use SilverStripe\View\Requirements;

/**
* TODO: describe.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #127

* TODO: bug when using default admin - always shows the message...
* Requires Security::login_recording config to be set to true.
*
* @property LeftAndMain $owner
Expand Down Expand Up @@ -69,14 +67,12 @@ public function init()

$message .= "The attempts were from " . implode(', ', $IPs) . '. ';

// TODO: add this call to action in a way that doesn't break out of the availabel space. Fix CSS?
// $message .= "If you suspect somebody else might be trying to access
// . "your account, please contact support.";
$message .= "If you suspect somebody else might be trying to access "
. "your account, please contact support.";
}
}
} else {
// New session - show last login attempt.
// TODO: this currently does NOT surface to the frontend in any way.
$lastLoginAttempt = LoginAttempt::get()->filter([
'MemberID' => $member->ID
])->sort('Created DESC')->First();
Expand Down
1 change: 0 additions & 1 deletion src/Feed/CwpAtomFeed.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
* CwpAtomFeed class
*
* This class is used to create an Atom feed.
* @todo Improve documentation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #127

* @package cwp-core
*/
use SilverStripe\Control\Controller;
Expand Down