Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove project from org #972

Merged
merged 23 commits into from
Jul 24, 2024
Merged

remove project from org #972

merged 23 commits into from
Jul 24, 2024

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Jul 19, 2024

fixes #939.

this PR implements feature of removing project from org on project page and org page. On project page, both project manager, org manager, and admin should be able to remove the project from org, but on org page, only org manager and admin can execute the action.

If someone can take a look at the translation for better standardization, it would be great.

@psh0078 psh0078 self-assigned this Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5c2cdcb. ± Comparison against base commit 1930cfd.

♻️ This comment has been updated with latest results.

@psh0078 psh0078 marked this pull request as ready for review July 19, 2024 09:27
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, I'd like some changes to how we're handling the project table actions. This should mean that no changes to ProjectTable are required.

@psh0078 psh0078 requested a review from hahn-kev July 24, 2024 03:41
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 minor things to change

@psh0078 psh0078 merged commit 43baf7c into develop Jul 24, 2024
9 checks passed
@psh0078 psh0078 deleted the feat/remove-project-from-org branch July 24, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove projects from org
2 participants