Invalidate GQL cache for org when a new project added to it #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that navigating to the org will show the new project.
This may avoid unnecessary data returning from GraphQL queries that need to refresh the list of projects.
rmunn
force-pushed
the
bug/933-invalidate-gql-for-projects-created-in-org
branch
from
3db96a6 to
b398515
Compare
hahn-kev
approved these changes
Jul 25, 2024
C# Unit Tests53 tests 53 ✅ 5s ⏱️ Results for commit bb835dc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933.
This PR attempts to only invalidate the
projectsfield of orgById to minimize the amount of information the next GQL query needs to pull, however in practice it looks like we'd have to run more granular queries to take advantage of that. URQL apparently does not reduce the info requested in a query just because the GraphQL cache is up-to-date for most of it (since that could fail if you're using persisted queries), so ourorgByIdquery pulls the entire org data even when it would only have needed to pull theprojectsfield. So we could, in theory, do away with commit 3db96a6. In practice, it might as well stay since it does no harm and may, in the future, do some good.