Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load listener #300

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix load listener #300

merged 2 commits into from
Dec 3, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 3, 2024

IDP-1340 ssp-base body event listener not triggered

Fixed

  • Directly call the disableUnsupportedFeatures and prettifyDates functions in the DOMContentLoaded listener instead of using addEventListener on the body.
  • Enable printable code download on Edge.

@briskt briskt requested a review from a team as a code owner December 3, 2024 01:37
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team December 3, 2024 01:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt mentioned this pull request Dec 3, 2024
Merged
hobbitronics
hobbitronics approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for cleaning up my mess. Btw do you have MFA set up locally?

@briskt
Copy link
Contributor Author

briskt commented Dec 3, 2024

Looks good. Thanks for cleaning up my mess. Btw do you have MFA set up locally?

No worries. Yes, I think so. Not sure I ever got it working with a fully-local setup though

@briskt briskt merged commit e279824 into main Dec 3, 2024
4 checks passed
@briskt briskt deleted the fix-load-listener branch December 3, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics