Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebAuthn prompt #298

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix WebAuthn prompt #298

merged 3 commits into from
Dec 2, 2024

Conversation

forevermatt
Copy link
Contributor

IDP-1330 Email issue from ITSE Support Account

Fixed

  • Avoid waiting for a 2nd on-load event before calling verifyWebAuthn()

Changed (non-breaking)

  • Revise "Try again" button's ID for clarity
  • Use "Try again" button's ID during offerRetry(), too

@forevermatt forevermatt requested a review from a team as a code owner December 2, 2024 16:35
@forevermatt forevermatt requested review from briskt, mtompset, jason-jackson and hobbitronics and removed request for a team December 2, 2024 16:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@forevermatt forevermatt requested a review from a team December 2, 2024 16:36
@forevermatt forevermatt merged commit 2ace687 into main Dec 2, 2024
4 checks passed
@forevermatt forevermatt deleted the feature/fix-webauthn-prompt branch December 2, 2024 16:47
@briskt
Copy link
Contributor

briskt commented Dec 3, 2024

This is a good solution. I did notice, though, that there were two other places where the same construct was used. One in review.twig and the other in new-backup-codes.twig. I filed a new issue and PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@briskt briskt Awaiting requested review from briskt briskt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forevermatt @briskt @jason-jackson