-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rekor-monitor workflow #526
Refactor rekor-monitor workflow #526
Conversation
0411ac6
to
7a3b221
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
- Coverage 64.02% 62.46% -1.57%
==========================================
Files 4 17 +13
Lines 303 1276 +973
==========================================
+ Hits 194 797 +603
- Misses 78 408 +330
- Partials 31 71 +40 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
d035f53
to
40083f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I only have a set of minor comments / nits.
40083f5
to
1b38f1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We chatted offline, but I've realized that this is going to introduce a lot of duplication, especially as we add more ways to monitor the log (CT consistency, CT monitoring, tile monitoring, etc). To avoid duplication, I'd suggest we:
- Keep only one GitHub Actions workflow,
reusable_monitoring.yml
seems like a generic enough name. - Keep consistency checks and monitoring under the same executable, but have a different executable for each monitored log (e.g
cmd/rekor_monitor/main.go
,cmd/ct_monitor/main.go
) - Keep reading the latest index from a checkpoint rather than the IdentityMetadata output. I think that file is still useful to later expand to include skipped entries though, so no need to revert any changes there.
Sorry for the pivot backwards, but hopefully this will keep the code easier to maintain.
Signed-off-by: linus-sun <[email protected]>
1b38f1d
to
cb917dd
Compare
5c0aa51
to
2b13744
Compare
Signed-off-by: linus-sun <[email protected]>
2b13744
to
2ea93b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Summary
As per the following doc, this PR refactors rekor-monitor to make running the identity monitor easier to configure through an updated input configuration, as well as adding better error handling and logic for determining what indices to run the identity monitor on in the case that the user does not input a given start or end index for the identity monitor portion of the reusable monitoring workflow.
Release Note
The identity monitor input configuration has been updated.
Documentation
The README has been updated accordingly with proper run instructions for the reusable monitoring workflow.