Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MatchedIndices functionality for certificate transparency #535

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

linus-sun
Copy link
Collaborator

@linus-sun linus-sun commented Nov 14, 2024

Summary

Per this doc, this PR adds the MatchedIndices function for certificate transparency logs, which filtered a set of certificate transparency logs entries on certificate identities and object identifier fields to find matching entries in preparation for setting up the certificate transparency monitor workflow.

This PR depends on #526 and #527.

Release Note

NONE

Documentation

N/A

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Project coverage is 62.81%. Comparing base (d271ec7) to head (7cae27c).
Report is 173 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ct/monitor.go 48.38% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   64.02%   62.81%   -1.22%     
==========================================
  Files           4       17      +13     
  Lines         303     1366    +1063     
==========================================
+ Hits          194      858     +664     
- Misses         78      424     +346     
- Partials       31       84      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

mihaimaruseac
mihaimaruseac previously approved these changes Nov 14, 2024
@haydentherapper
Copy link
Contributor

LGTM pending other PRs.

mihaimaruseac
mihaimaruseac previously approved these changes Nov 19, 2024
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the other PR!

@linus-sun linus-sun force-pushed the linussun/ct-monitor-workflow branch 2 times, most recently from 64feecf to 7867622 Compare November 20, 2024 00:57
@haydentherapper haydentherapper enabled auto-merge (squash) November 20, 2024 00:58
@haydentherapper
Copy link
Contributor

@linus-sun There's a lint failure.

Signed-off-by: linus-sun <[email protected]>
@haydentherapper haydentherapper enabled auto-merge (squash) November 20, 2024 01:04
@haydentherapper haydentherapper merged commit 2d5580b into sigstore:main Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants