Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not block the login page in globalMiddleware #543

Merged
merged 5 commits into from
Oct 17, 2023
Merged

fix: Do not block the login page in globalMiddleware #543

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e3f36f
added check to ensure login page does not get blocked by middleware
zoey-kaiser Oct 11, 2023
4bf4407
Update 4.protecting-pages.md
zoey-kaiser Oct 16, 2023
866319d
Update 2.nuxt-config.md
zoey-kaiser Oct 16, 2023
1c9aacb
Merge branch 'main' into disable-middleware-on-login-page
zoey-kaiser Oct 16, 2023
ab55dd8
Update 2.nuxt-config.md
zoey-kaiser Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/runtime/middleware/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ export default defineNuxtRouteMiddleware((to) => {
return
}

// We do not want to block the login page when the local provider is used
if (authConfig.provider?.type === 'local') {
const loginRoute: string | null = authConfig.provider?.pages?.login
if (loginRoute && loginRoute === to.path) {
zoey-kaiser marked this conversation as resolved.
Show resolved Hide resolved
return
}
}

/**
* We do not want to enforce protection on `404` pages (unless the user opts out of it by setting `allow404WithoutAuth: false`).
*
Expand Down