Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not block the login page in globalMiddleware #543

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

zoey-kaiser
Copy link
Member

Closes #410

Ensures the globalMiddleware will not block the login page defined in the nuxt.config.

  • If blocked, will lead to an endless redirect, between loginPage (gets Blocked) -> loginPage (gets Blocked) causing application to crash
  • removes confussion, as the globalMiddleware does not block the default authjs login page

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser zoey-kaiser merged commit 2f35849 into main Oct 17, 2023
3 checks passed
@zoey-kaiser zoey-kaiser deleted the disable-middleware-on-login-page branch October 17, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Redirect - Global Middleware
2 participants