-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA 중감점검] 공개상담 관련한 이슈 해결 #281
Merged
Merged
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0a873cd
Update bug.md
kyuhho eabf36e
Update pull_request_Template.md
kyuhho 6309556
Merge remote-tracking branch 'origin/dev'
kyuhho fc50fc1
Merge remote-tracking branch 'origin/dev'
kyuhho 19ad309
Merge pull request #243 from sharemindteam/dev
rmdnps10 dcbdcf6
Merge pull request #245 from sharemindteam/hotfix/time-select
rmdnps10 8aaaf0e
Revert "[Hotfix] 시간 선택 모달 디바이스에 따라 스타일 깨짐 오류"
rmdnps10 3d7122b
Merge pull request #246 from sharemindteam/revert-245-hotfix/time-select
rmdnps10 f44ffb1
Merge pull request #248 from sharemindteam/dev
rmdnps10 d391d04
Revert "Revert "[Hotfix] 시간 선택 모달 디바이스에 따라 스타일 깨짐 오류""
rmdnps10 d8a206e
Merge pull request #249 from sharemindteam/revert-246-revert-245-hotf…
rmdnps10 146f25f
Merge pull request #265 from sharemindteam/dev
rmdnps10 f2f5105
Merge pull request #275 from sharemindteam/dev
rmdnps10 910b974
Merge branch 'dev' of https://github.com/sharemindteam/sharemind-clie…
rmdnps10 0ada715
Refactor: Maintaining the state of the letter writing page when no ca…
rmdnps10 ce3d668
Fix: Activate the send button immediately when loading a letter #254
rmdnps10 da106d0
Style: ongoingconsultbox style error fix
rmdnps10 7ae4ee9
Feat: 마인더 편지 답장에서 보낸 시간 표시에 api response값의 updated2 값 이용
rmdnps10 d39269e
Merge branch 'dev' of https://github.com/sharemindteam/sharemind-clie…
rmdnps10 0bda485
Chore: delete console.log
rmdnps10 b4293bf
Fix: consult category init value setting, add 연애갈등 category #280
rmdnps10 f180555
Fix: fix style error of open consult card, mapping scrap, like #280
rmdnps10 d3fdcba
Feat: 마인더 공개상담 답변 창에서 좋아요, 스크랩뷰 없애기 #280
rmdnps10 2ad925e
Fix: Change res to res2 so that the accept button is visible only to …
rmdnps10 5e10a05
Feat: 셰어 상담 탭 공개 상담 리스트 좋아요, 스크랩 여부에 따른 하트, 북마크 채우기 여부 표시 #280
rmdnps10 568dfdc
Fix: 공개상담 결제 완료시 blabla~ 삭제 #280
rmdnps10 25e9db0
Fix: 일대다상담 신청하기 상담 방식 선택 문구 수정 #280
rmdnps10 e4e747b
Feat: 셰어 공개 상담 댓글에서 마인더 프로필 클릭 시 마인더 프로필 페이지로 이동 #280
rmdnps10 2f94f7a
Chore: 나중에 사용할 수도 있는 코드 주석 추가 #280
rmdnps10 91049a4
Chore: 나중에 사용할 수도 있는 코드 주석 추가2 #280
rmdnps10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ function MainQuestionSection() { | |
</div> | ||
<Space height="1rem" /> | ||
</MainQuestionText> | ||
<ButtonList> | ||
{/* <ButtonList> | ||
<ButtonItem> | ||
<HeartIcon /> | ||
<Caption1 color={Grey2}>{card?.totalLike}</Caption1> | ||
|
@@ -55,7 +55,7 @@ function MainQuestionSection() { | |
<SaveResizeIcon /> | ||
<Caption1 color={Grey2}>{card?.totalScrap}</Caption1> | ||
</ButtonItem> | ||
</ButtonList> | ||
</ButtonList> */} | ||
</MainQuestionWrapper> | ||
); | ||
} | ||
|
@@ -103,22 +103,22 @@ const Circle = styled.div` | |
background-color: ${Grey3}; | ||
`; | ||
|
||
const ButtonList = styled.div` | ||
display: flex; | ||
gap: 1.2rem; | ||
`; | ||
// const ButtonList = styled.div` | ||
// display: flex; | ||
// gap: 1.2rem; | ||
// `; | ||
|
||
const ButtonItem = styled.div` | ||
border-radius: 0.8rem; | ||
background: ${Grey6}; | ||
display: flex; | ||
padding: 0.6rem 1.2rem 0.6rem 0.6rem; | ||
align-items: center; | ||
gap: 0.4rem; | ||
`; | ||
// const ButtonItem = styled.div` | ||
// border-radius: 0.8rem; | ||
// background: ${Grey6}; | ||
// display: flex; | ||
// padding: 0.6rem 1.2rem 0.6rem 0.6rem; | ||
// align-items: center; | ||
// gap: 0.4rem; | ||
// `; | ||
|
||
const SaveResizeIcon = styled(SaveIcon)` | ||
width: 2rem; | ||
height: 2rem; | ||
`; | ||
// const SaveResizeIcon = styled(SaveIcon)` | ||
// width: 2rem; | ||
// height: 2rem; | ||
// `; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 사용되지 않는 주석이면 지워주세요! |
||
export default React.memo(MainQuestionSection); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 주석이 추후에 사용되는 코드이면 주석으로 TODO: use later 이런식으로 표기해주고, 사용되지 않는다면 지워주시면 좋을거 같아요!