[QA 중감점검] 공개상담 관련한 이슈 해결 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[0426] main 배포
[Hotfix] 시간 선택 모달 디바이스에 따라 스타일 깨짐 오류
Revert "[Hotfix] 시간 선택 모달 디바이스에 따라 스타일 깨짐 오류"
…ix/time-select Revert "Revert "[Hotfix] 시간 선택 모달 디바이스에 따라 스타일 깨짐 오류""
[0429 수정사항 반영] 메인 브랜치 배포
[0430] main 배포
… into hotfix/time-select
…tegory is selected #278
… into refactor/letter
✅ Deploy Preview for candid-semolina-d0db42 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kyuhho
reviewed
May 4, 2024
| @@ -55,7 +55,7 @@ function MainQuestionSection() { | |||
| <SaveResizeIcon /> | |||
| <Caption1 color={Grey2}>{card?.totalScrap}</Caption1> | |||
| </ButtonItem> | |||
| </ButtonList> | |||
| </ButtonList> */} | |||
There was a problem hiding this comment.
해당 주석이 추후에 사용되는 코드이면 주석으로 TODO: use later 이런식으로 표기해주고, 사용되지 않는다면 지워주시면 좋을거 같아요!
Comment on lines
106
to
123
| const ButtonList = styled.div` | ||
| display: flex; | ||
| gap: 1.2rem; | ||
| `; | ||
| // const ButtonList = styled.div` | ||
| // display: flex; | ||
| // gap: 1.2rem; | ||
| // `; | ||
|
|
||
| const ButtonItem = styled.div` | ||
| border-radius: 0.8rem; | ||
| background: ${Grey6}; | ||
| display: flex; | ||
| padding: 0.6rem 1.2rem 0.6rem 0.6rem; | ||
| align-items: center; | ||
| gap: 0.4rem; | ||
| `; | ||
| // const ButtonItem = styled.div` | ||
| // border-radius: 0.8rem; | ||
| // background: ${Grey6}; | ||
| // display: flex; | ||
| // padding: 0.6rem 1.2rem 0.6rem 0.6rem; | ||
| // align-items: center; | ||
| // gap: 0.4rem; | ||
| // `; | ||
|
|
||
| const SaveResizeIcon = styled(SaveIcon)` | ||
| width: 2rem; | ||
| height: 2rem; | ||
| `; | ||
| // const SaveResizeIcon = styled(SaveIcon)` | ||
| // width: 2rem; | ||
| // height: 2rem; | ||
| // `; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
QA 전에, 공개상담과 관련되어 있는 이슈들을 정리해서 해결했습니다.
자세한 이슈 내용들은, #280 에서 확인부탁드립니다!
Related Issues
관련된 이슈 number를 작성해주세요. #280
To Reveiwer
리뷰어가 주목해야할 사항들을 작성해주세요