Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.7.1 #555

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Release 6.7.1 #555

merged 11 commits into from
Aug 29, 2024

Conversation

ckadluba
Copy link
Member

Updated patch version after release
* Rather have 5.1 than 5.2 because 5.1 is LTS
* Fixes issue #544 (partly) and issue #552
* Fixed vulnerability by updating xunit to 2.9.0.
* Fixed new warnings in test code.

Related issue: #544

Related Work Items: #5
Fixed vulnerability by directly referencing transitive dependency System.Private.Uri (GHSA-xhfc-gr8f-ffwc)

Related issue: #544
Fixed vulnerability by directly referencing transitive dependency System.Formats.Asn1 (GHSA-447r-wph3-92pm)

Related issue: #544
…ystem.Formats.Asn1 (GHSA-447r-wph3-92pm, issue #544)

* Fixed vulnerability by directly referencing transitive dependency System.Private.Uri (GHSA-xhfc-gr8f-ffwc, issue #544)
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ckadluba ckadluba merged commit 9f9641b into main Aug 29, 2024
11 checks passed
@cancakar35
Copy link
Member

@ckadluba Why do we directly reference System.Private.Uri?

@ckadluba
Copy link
Member Author

Hi @cancakar35!

Because there was a warning about a vulnerability when using dotnet nuget audit (see discussion here #544 (comment)) and only referencing System.Private.Uri fixed it. As cremor noted, this might be a false positive caused by the SDK, but I didn't want to take the risk or let the sink have any warnings about vulnerabilities. Hopefully we can remove this again when MS fixes it the false positive or we upgrade the TFMs in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants