-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated transitive dependency on Microsoft.NETCore.Targets #580
Comments
david-brink-talogy
added a commit
to david-brink-talogy/serilog-sinks-mssqlserver
that referenced
this issue
Oct 2, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 3, 2024
…entifier Remove runtime identifiers, fixes #580
@david-brink-talogy thank you very much for investigating and fixing this. It is highly appreciated. :) After the PR was merged, the dev release 7.0.2-dev-00104 was published on nuget.org. We are thankful to anyone who could give it a spin and tell us of any problems. |
Merged
ckadluba
added a commit
that referenced
this issue
Oct 18, 2024
* Fixed issue #580: Removed deprecated transitive dependency on Microsoft.NETCore.Targets by removing runtime identifier (thanks to @david-brink-talogy) * Fixed issues #540 and #541 in README * Added performance tests including a GitHub actions workflow * Minor cleanups and fixes
Merged
ckadluba
added a commit
that referenced
this issue
Oct 18, 2024
* Fixed issue #580: Removed deprecated transitive dependency on Microsoft.NETCore.Targets by removing runtime identifier (thanks to @david-brink-talogy) * Fixed issues #540 and #541 in README * Added performance tests including a GitHub actions workflow * Minor cleanups and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Serilog.Sinks.MsSqlServer has a dependency on System.Private.Uri, which in turn depends on package Microsoft.NETCore.Targets, which is listed as deprecated on nuget.org.
An explicit reference to System.Private.Uri was added on #555 to address a vulnerability. The README for this package notes that "Internal implementation package not meant for direct consumption. Please do not reference directly". System.Private.Uri is only seen as a dependency when a project specifies runtime identifiers in its configuration.
Serilog.Sinks.MsSqlServer does not depend on deprecated packages.
[x] .NET 6
[ ] .NET Framework 4.8
[ ] .NET Framework 4.7
[ ] .NET Framework 4.6
OS: Windows 10
The text was updated successfully, but these errors were encountered: