Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Custom message unit test setup #399

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Dec 11, 2024

Changes

ticket: []

Additional Notes

  • This unit test setup currently needs additional work to work properly:
    • replace CustomMessage with ParsedBotMessageBody

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho self-assigned this Dec 11, 2024
@liamcho liamcho marked this pull request as draft December 11, 2024 06:52
Copy link

Size Change: +1.3 kB (+0.21%)

Total Size: 620 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB -1 B (-0.02%)
./dist/__bundle-7c3d40f4-********.js 0 B -21 B (removed) 🏆
./dist/__bundle-b5ef7de4-********.js 0 B -891 B (removed) 🏆
./dist/index-********.js 305 kB +934 B (+0.31%)
./dist/index.umd.js 290 kB +618 B (+0.21%)
./dist/Placeholder.error-********.js 344 B -1 B (-0.29%)
./dist/Placeholder.noChannels-********.js 182 B -1 B (-0.55%)
./dist/Placeholder.noMessages-********.js 182 B -1 B (-0.55%)
./dist/PlaceholderCommon-********.js 244 B -1 B (-0.41%)
./dist/TokensBody-********.js 8.92 kB -243 B (-2.65%)
./dist/__bundle-1febfea9-********.js 887 B +887 B (new file) 🆕
./dist/__bundle-8b4f432b-********.js 21 B +21 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/index.es.js 172 B
./dist/Placeholder.loading-********.js 184 B
./dist/style.css 9.59 kB

compressed-size-action

@liamcho liamcho merged commit 42dbdcd into feat/AC-44290-compare-markdown-libraries-2 Dec 11, 2024
7 of 8 checks passed
@liamcho liamcho deleted the feat/AC-44290-compare-markdown-libraries-2_unit-test-setup-2 branch December 11, 2024 08:18
@liamcho
Copy link
Contributor Author

liamcho commented Dec 11, 2024

should not have been merged. Merged by mistake. merged branch has been rolled back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant