Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Custom message unit test setup (duplicate) #398

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Dec 10, 2024

Changes

ticket: []

Additional Notes

  • This unit test setup currently needs additional work to work properly: CustomMessage needs to be wrapped by ChatProvider.

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho requested a review from bang9 December 10, 2024 06:10
@liamcho liamcho self-assigned this Dec 10, 2024
@liamcho liamcho marked this pull request as draft December 10, 2024 06:10
{message && (
<div data-testid="wowwow">
{/*FIXME: Note that below component must be wrapped with ChatProvider.*/}
<CustomMessage message={message} activeSpinnerId={-1} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that CustomMessage must be wrapped with ChatProvider in order for this app to work.

Copy link

Size Change: -17 kB (-2.68%)

Total Size: 620 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB -3 B (-0.07%)
./dist/__bundle-7c3d40f4-********.js 0 B -21 B (removed) 🏆
./dist/__bundle-b5ef7de4-********.js 0 B -891 B (removed) 🏆
./dist/index-********.js 305 kB -8.63 kB (-2.75%)
./dist/index.umd.js 290 kB -8.15 kB (-2.73%)
./dist/Placeholder.error-********.js 343 B -5 B (-1.44%)
./dist/Placeholder.loading-********.js 184 B -1 B (-0.54%)
./dist/Placeholder.noChannels-********.js 182 B -7 B (-3.7%)
./dist/Placeholder.noMessages-********.js 182 B -4 B (-2.15%)
./dist/PlaceholderCommon-********.js 245 B -2 B (-0.81%)
./dist/TokensBody-********.js 8.92 kB -239 B (-2.61%)
./dist/__bundle-1febfea9-********.js 887 B +887 B (new file) 🆕
./dist/__bundle-8b4f432b-********.js 21 B +21 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/index.es.js 173 B
./dist/style.css 9.59 kB

compressed-size-action

@liamcho liamcho mentioned this pull request Dec 10, 2024
5 tasks
@liamcho liamcho force-pushed the feat/AC-44290-compare-markdown-libraries-2 branch from 0ab9f14 to cd901b2 Compare December 11, 2024 04:02
@liamcho liamcho changed the title test: Custom message unit test setup test: Custom message unit test setup (duplicate) Dec 11, 2024
@liamcho
Copy link
Contributor Author

liamcho commented Dec 11, 2024

duplicate of #399

@liamcho liamcho closed this Dec 11, 2024
@bang9 bang9 deleted the feat/AC-44290-compare-markdown-libraries-2_unit-test-setup branch December 17, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant