-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve sidekiq errors #121
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5864907
229 - correct spelling of the propogate method
ShanaLMoore 440424c
229 - handle nil case and casue of sidekiq sentry error
ShanaLMoore b011efd
229 - handle nil case and casue of sidekiq sentry error
ShanaLMoore 73aead5
rubocop updates
ShanaLMoore 781422b
299 - override Hyrax::VisibilityPropagator::NullVisibilityPropogator
ShanaLMoore 7986190
299 - override Hyrax::VisibilityPropagator::NullVisibilityPropogator
ShanaLMoore 47a576b
299 - override Hyrax::VisibilityPropagator::NullVisibilityPropogator
ShanaLMoore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# frozen_string_literal: true | ||
|
||
# OVERRIDE HYRAX 3.4.1 to handle nil case and casue of sidekiq sentry error | ||
# TODO: why is depositor coming across as nil? | ||
module ContentEventJobDecorator | ||
# OVERRIDE HYRAX 3.4.1 to handle nil case and casue of sidekiq sentry error | ||
# log the event to the users profile stream | ||
def log_user_event(depositor) | ||
depositor&.log_profile_event(event) | ||
end | ||
end | ||
|
||
ContentEventJob.prepend(ContentEventJobDecorator) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# frozen_string_literal: true | ||
|
||
## OVERRIDE HYRAX 3.4.1 to correct method spelling that causes sidekiq errors. | ||
require_dependency Hyrax::Engine.root.join('app', 'services', 'hyrax', 'visibility_propagator').to_s | ||
|
||
Hyrax::VisibilityPropagator::NullVisibilityPropogator.class_eval do | ||
## OVERRIDE HYRAX 3.4.1 to correct method spelling that causes sidekiq errors. | ||
# @return [void] | ||
# @raise [RuntimeError] if we're in development mode | ||
def propagate | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From @ShanaLMoore : propogate => propagate |
||
# rubocop:disable Performance/Caller | ||
message = "Tried to propagate visibility to members of #{source} " \ | ||
"but didn't know what kind of object it is. Model " \ | ||
"name #{source.try(:model_name)}. Called from #{caller[0]}." | ||
# rubocop:enable Performance/Caller | ||
|
||
Hyrax.logger.warn(message) | ||
Rails.env.development? ? raise(message) : :noop | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @ShanaLMoore
This may be a temp fix to help reduce the noise of sidekiq sentry error and prevent it from clogging up our limit rate too fast.
However, why would depositor be nil is a Q we should be able to answer.
Consider putting this into its own ticket.
Ref #231