Resolve sidekiq errors #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangewolf
commented
Oct 26, 2022
| # frozen_string_literal: true | ||
|
|
||
| # OVERRIDE HYRAX 3.4.1 to handle nil case and casue of sidekiq sentry error | ||
| # TODO: why is depositor coming across as nil? |
There was a problem hiding this comment.
From @ShanaLMoore
This may be a temp fix to help reduce the noise of sidekiq sentry error and prevent it from clogging up our limit rate too fast.
However, why would depositor be nil is a Q we should be able to answer.
Consider putting this into its own ticket.
Ref #231
orangewolf
commented
Oct 26, 2022
| ## OVERRIDE HYRAX 3.4.1 to correct method spelling that causes sidekiq errors. | ||
| # @return [void] | ||
| # @raise [RuntimeError] if we're in development mode | ||
| def propagate |
There was a problem hiding this comment.
From @ShanaLMoore :
propogate => propagate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ref #136
https://utk-hyku-staging.notch8.cloud/sidekiq/retries