Hyrax::VisibilityPropagator does not support AllinsonFlex objects so visibility does not propagate down

[crisr15]

Staging: NoMethodError: undefined method 'propagate' for #<Hyrax::VisibilityPropagator::NullVisibilityPropogator:0x0000560eb785d498> Did you mean? propogate caused by running an importer

Details

Issue originates in Hyrax::VisibilityPropagator. A bug exists in the nested class, NullVisibilityPropogator which is misspelling propagate.

However the larger issue is that the source type is not handled by a different propagator and falls to the NullVisibilityPropogator. Only Hyrax::WorkBehavior and Hyrax::Resource are expected source type classes, and with AllinsonFlex, we are most likely getting an AllinsonFlex source object. However since it only occurs in Bulkrax imports (unable to duplicate via UI updates), it may have a different cause.

One end result of this error is that when a CSV is import which contains a visibility column, the file set will correctly be assigned the correct visibility, but that visibility does not propagate down to its files.

UTK needs to override the Hyrax::VisibilityPropagator until AllinsonFlex can support this behavior.

See also samvera-labs/allinson_flex#107

Example of Work with mixed visibility
https://dc.utk-hyku-staging.notch8.cloud/concern/images/f0bdb789-c1e4-4e79-8ef8-3ae6b85249d4?locale=en

Example of Attachment with restricted visibility but Fileset is open
https://dc.utk-hyku-staging.notch8.cloud/concern/parent/f0bdb789-c1e4-4e79-8ef8-3ae6b85249d4/attachments/e97f9668-41a9-4143-9b39-6390806af59a

Testing

• Execute a Bulkrax Import with this CSV vis_test.csv
• After import is completed, observe that the Attachment and its FileSet both have private

[laritakr]

see samvera/bulkrax#671

[ShanaLMoore]

@kirkkwang What is the best way to test this?

[kirkkwang]

@ShanaLMoore I've updated the ticket with a basic test. Essentially, if you import a record with a file set from a remote URL, the Attachment and the FileSet both should have the same visibility. Setting the Attachment to restricted on the CSV should then set both the Attachment and its FileSet to private after import.

[ShanaLMoore]

This passes QA. The test file needed to be updated (rights => rights_statement):

vis_test.csv

The image has an attachment, which has a fileset.

The Attachment has a restricted value in the visibility column. Once uploaded, it's displayed as private. Its file set's visibility is set to private too.

Nice work @kirkkwang @laritakr 🎉

Sidekiq has no retry jobs: