Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] Test Ingest #133

Closed
crisr15 opened this issue Oct 26, 2022 · 6 comments
Closed

[2] Test Ingest #133

crisr15 opened this issue Oct 26, 2022 · 6 comments
Assignees
Labels

Comments

@crisr15
Copy link

crisr15 commented Oct 26, 2022

Test imports and confirm they are coming in properly.

We may sample data from client.

Sample files: https://assaydepot.slack.com/archives/C0396LSM06P/p1666654210407659

@ShanaLMoore ShanaLMoore moved this from Ready for Development to In Development in utk-hyku Oct 26, 2022
@ShanaLMoore ShanaLMoore changed the title Test Ingest [2] Test Ingest Oct 26, 2022
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 26, 2022

Tested with the following details but this will need to be redone once #131 is complete:

metadata profile: https://dc.utk-hyku-staging.notch8.cloud/profiles/14?locale=en
sample file: shaina_boydcs_with_files-small.csv
importer: https://dc.utk-hyku-staging.notch8.cloud/importers/41?locale=en#work-entries

Advised client on how their spreadsheets need to change: https://assaydepot.slack.com/archives/C0396LSM06P/p1666737305132069?thread_ts=1666654210.407659&cid=C0396LSM06P

@ShanaLMoore ShanaLMoore moved this from In Development to Ready for Development in utk-hyku Oct 31, 2022
@ShanaLMoore ShanaLMoore moved this from Ready for Development to In Development in utk-hyku Nov 1, 2022
@ShanaLMoore ShanaLMoore moved this from In Development to Ready for Development in utk-hyku Nov 1, 2022
@ShanaLMoore ShanaLMoore moved this from Ready for Development to In Development in utk-hyku Nov 9, 2022
@kirkkwang
Copy link
Contributor

kirkkwang commented Nov 9, 2022

@ShanaLMoore

LaRita and I ran the import with the exact CSV attached, but it looks like it didn't overwrite your Works and instead amended it (incorrectly) so we got something like this.

Image

From my understanding, an Attachment should only ever have 1 FileSet is that correct?

Also getting these errors in Sidekiq

Image

@kirkkwang
Copy link
Contributor

After changing the identifiers, we got a successful import.

https://dc.utk-hyku-staging.notch8.cloud/concern/images/78f93bb9-ecc5-46bb-9943-9422a317aabd?locale=en

@kirkkwang
Copy link
Contributor

@crisr15

Was there talks of making the MODS and PRESERVATION attachments private? Is so the CSV needs to have a visibility header and the files they wish to be private need to be restricted.

I did that test and on the Work level, the visibility gets set.

Image

However, the FileSet did not get the visibility of its parent.

Image

We think this is because the Hyrax::VisibilityPropagator was acting funky. @laritakr thinks this is because its receiving an Allinson Flex type object and doesn't know what to do with it.

https://github.com/samvera/hyrax/blob/main/app/services/hyrax/visibility_propagator.rb#L11-L20

@laritakr
Copy link
Contributor

laritakr commented Nov 9, 2022

Updated ticket #136 for above issue, and created #180 related to the fits error we are also seeing.

Still need a ticket related to the issue where repeating an ingest incorrectly amended the filesets.

@kirkkwang
Copy link
Contributor

Created #181 related to the reimport issue

@kirkkwang kirkkwang moved this from In Development to Code Review in utk-hyku Nov 9, 2022
Repository owner moved this from Code Review to Done in utk-hyku Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants